Guriddo » Topic: Wrong hovering effect in actions formatter of jqGrid 4.1.0

Wrong hovering effect in actions formatter of jqGrid 4.1.0

Guriddo
Wrong hovering effect in actions formatter of jqGrid 4.1.0

This topic has 10 replies, 3 voices, and was last updated 14 years, 9 months ago by OlegK.

Creator

Topic
June 15, 2011 at 10:15 am #78570

OlegK
Participant

Hello Tony,

The bug report is based on this my answer on the stackoverflow. The 4.1.0 version of the actions formatter has new hovering effects on the action buttons which works wrong on the line which is in the inline editing mode after the clicking of the “Edit” action button. The hovering shows wrong image from the middle of the corresponding background image:

I suggest to change the action onmouseover for div.ui-inline-save, div.ui-inline-cancel from

jQuery(this).addClass('ui-state-hover');
to
jQuery(this).addClass('ui-state-hover'); jQuery('span',this).removeClass('ui-state-hover');
Creator

Topic

Viewing 10 replies - 1 through 10 (of 10 total)

Author

Replies
June 15, 2011 at 11:22 am #98245

tony
Keymaster

Thanks Oleg.

I'm considering to remove these effects.

Tony

June 15, 2011 at 12:31 pm #98247

OlegK
Participant

Hello Tony,

in general the hovering effects on the icons seems good in my opinion. One should just fix the code. The demo looks prity good. I added here the switching of action buttons in case of the standard editing.

The only thing which I personally not like in the actions formatter code is the usage of “onmouseover” and “onmouseout” instead of unobtrusive style

June 16, 2011 at 10:33 am #98252

tony
Keymaster

Oleg,

I have fixed the problem. It was really travial copy/paste problem

Not sure that unobtrusive style is applicable in these days.

Imagine which current internet user can work with Java Script disabled

Every solution which work and is usefull for the users is a good solution

I have finished the demos for 4.0 version. You can look here:

http://trirand.com/blog/jqgrid/jqgrid.html

Regards

Tony

June 16, 2011 at 1:59 pm #98256

OlegK
Participant

Tony,

I find your fix very good (it looks better as my suggestion), but you don't insterted jqID

June 16, 2011 at 4:58 pm #98259

tony
Keymaster

Oh, Forgot for these. Will do the needed.

Thanks.

June 17, 2011 at 10:29 am #98268

tony
Keymaster

Oleg,

1) I can not reproduce this. (it work ok for me. If I remember right I have fixed this)

2) Will see

3) What you mean with this? The script (using jqModal) try to focus on the first input field.

4) Esc is supported with closeOnEscape : true in the options (I just checked this and closeOnEscape worked for me) . Enter will be added maybe later.

Kind Regards

Tony

June 17, 2011 at 1:06 pm #98274

OlegK
Participant

You are right Tony, the most of problems not exist more in the 4.1 version.

The problem with Reset button in the Singe Value Search dialog you can reproduce on the demo, which uses jqGrid 4.0, but the same demo work correct with jqGrid 4.1.

The problem with deleting of the last rule is the following. I mean that it is possible to click on the buttom which I mark red:

After that one receive the dialog

which is misunderstandable for many people.

The setting of focus in the Serching Dialog is probably more the question of the taste or ergonomy. Currently you have it on ADD/OR:

In my opinion the best place would be the last edit field:

See the demo from the answer.

Some additional problem is that it is not so easy to impelment change focus behavior in the new searching dialog because the fields of the dialog fill be repaint. I have to overwrite/chain the reDraw method. It would be nice to have some additional events in the the Filter dialog. For example new events like

August 13, 2011 at 11:02 am #98593

kobruleht
Participant

In 4.1.2 if inline edit is started using edit action button and clicked in other row, old row remains in edit mode.

How to fix this so that inline edit is terminated if other row editing starts or if other row is clicked ?

August 14, 2011 at 9:43 am #98597

tony
Keymaster

Hello,

This is not a bug, but feature and a way the action formatter work.

You can simulate the behaviour without the formatter action – look at the demos.

Kind REgards

August 14, 2011 at 2:30 pm #98622

OlegK
Participant

Hello Tony,

in my opinion kobruleht
Author

Replies