Guriddo » Topic: wrong calculation of the width of the grid if shrinkToFit is false

wrong calculation of the width of the grid if shrinkToFit is false

Guriddo
wrong calculation of the width of the grid if shrinkToFit is false

This topic has 5 replies, 2 voices, and was last updated 15 years, 3 months ago by OlegK.

Creator

Topic
December 12, 2010 at 11:22 pm #77732

OlegK
Participant

Hello Tony!

It seems I found one bug in the jqGrid
Creator

Topic

Viewing 5 replies - 1 through 5 (of 5 total)

Author

Replies
January 8, 2011 at 7:24 pm #97082

OlegK
Participant

Hello Tony!

Could you find time to look in my suggestion, so that the corresponding bug fix could be included in the next release of jqGrid. I posted demos which reproduce the problem and which demonstrate that after changing only one line of the jqGrid code the problem could be fixed.

Thank you
Oleg

January 9, 2011 at 2:23 pm #97083

tony
Keymaster

Oleg,

Thank you for remaind us

Currently we are busy with the new version of jqSuite,

http://www.trirand.net/demochartphp.aspx

which will include charts and a ton of improvements in the php grid.

I see all the posts in this forum instead and next week I will really work on all of your recommendations and fixes.

Of course I will look in all other posts.

Thank you again for all your efforts

Best Regards

Tony

January 9, 2011 at 9:45 pm #97087

OlegK
Participant

Thanks for the information, Tony!

jqChart seems me very interesting. Only one small advice from me. Microsoft charts has many 3D effects. Your jqChart has on the other side very nice animation effects and good interaction. I would recommend you include some gradient effects in some your demos. Including CSS with gradient effects (see my old demo) in the “Column and Bar charts” for example makes almost no additional work, but the charts could look even more better.

Best wishes
Oleg

January 16, 2011 at 3:54 pm #97160

tony
Keymaster

Oleg,

I think tha the real fix should be:

if (ts.p.shrinkToFit === false) {initwidth += brd*cl;}

This is true since before this condition we have

if (isSafari) { brd=0; }
$.each(ts.p.colModel, function(i) {

January 17, 2011 at 12:03 am #97176

OlegK
Participant

Thank you Tony!

Now the code on GitHub contain all changes which I need. I will test the code inside of copy of real project which I developed about one year ago and where I should make a small update in the month. If I will find any problem I will post my results here as usual.

Best regards
Oleg
Author

Replies