Hello Tony,

with the line “if (p.gridComplete = complete) {” I was not sure myself.

If you want I could check other jqGrid-files (not only grid.base.js) when I found a little time for it.

Regards
Oleg

Hello Tony!

My main goal was to show you, that the usage of JSLint can be really very helpful. So it would be good if you include JSLint in the process of the future release builds of jqGrid.

I also think (like you) that one should be very careful if one makes a lot of changes in a working code. But nevertheless please don’t forget to fix some clear bugs which I described in my two posts: like usage $s or ts instead of $t in grid.custom.js (see /blog/?page_id=393/bugs/more-bug-fixes-and-other-suggestions-found-with-respect-of-jslint-tool/) or missing “var” declarations. (Otherwise I had spend a lot of my time for nothing)

One more remark: I war at the beginning much more careful with changes of the “Equal” and “Not Equal” operators (“==” and “!==”) to “Identically Equal” and “Not Identically Equal” (“===” and “!===”), which makes comparison without any type conversion.

Hello Tony!

I tested the current version from GitHub and found till now only one small problem.

I have one Grid where a column has formatter: 'showlink'. The data send from server have sometime null values. Previous version on jqGrid formated this value like an empty string. The current version from GitHub instead format 'null' value like clickable null. It seems to me that the line 235

cellval = cellval+"";

shortly added inside of $.fn.fmatter.showlink function in the file jquery.fmatter.js should be removed. At least I don't undestand it's meaning.

Now you undestand, that working with JSLint tooks not so little fime. I hope you will not regret, that begin modifing of jqGrid corresponds of JSLint recomendations.

Inspide of large number of changes in jqGrid I found, that some bugs is not yet changed. For example, the line 160 of grid.custom.js looks the same as before:

if($t.p.footerrow) { $(".ui-jqgrid-sdiv","#gbox_"+$s.p.id).slideUp("fast"); }

but it should be fixed to

if($t.p.footerrow) { $(".ui-jqgrid-sdiv","#gbox_"+$t.p.id).slideUp("fast"); }

One more clear bug, which I described befor (see /blog/?page_id=393/bugs/more-bug-fixes-and-other-suggestions-found-with-respect-of-jslint-tool/) is in the lines 203-204 of grid.jqueryui.js. The code

if (opts.classname) {