Guriddo » Topic: small improvements of the jqGrid code with respect of ReSharper 6

small improvements of the jqGrid code with respect of ReSharper 6

Guriddo
small improvements of the jqGrid code with respect of ReSharper 6

This topic has 4 replies, 2 voices, and was last updated 14 years, 5 months ago by OlegK.

Creator

Topic
July 28, 2011 at 1:33 am #78785

OlegK
Participant

Hello Tony,

The new version of ReSharper (http://www.jetbrains.com/resharper/) gives many hints which halps to improve a litle JavaScript code of jqGrid. If you have an interest I could post you the recomendations one after another or you can buy the tool yourself.

Here is example of recommendation about grid.grouping.js:

1) the line 77
Creator

Topic

Viewing 4 replies - 1 through 4 (of 4 total)

Author

Replies
July 28, 2011 at 12:41 pm #98500

tony
Keymaster

Thanks Oleg,

I will check these at end of week. Will let you know

Regards

Tony

August 6, 2011 at 6:34 pm #98557

OlegK
Participant

It's just an reminder. You promissed to read my suggestions. ReSharper could help to remove unused parameters used in callback functions in defferent places of jqGrid. It point additionally to some places where uninitialized variables could be used. All this is not clitical, but can improve the code.

Please read another bug report too which I resently posted.

Best regards
Oleg

August 14, 2011 at 11:30 am #98609

tony
Keymaster

Hello Oleg,

Just do these fixes in GitHub. Thanks again. Going to look at the others.

Kind Regards

January 15, 2012 at 11:22 pm #99349
OlegK
Participant
Hello Tony,

I use ReSharper 6.1 for my projects and find it's suggestions very clear. It can help in one click to fix the problem. If I open the current code of jqGrid I can see many small problems identivied by ReSharper. It's mostly the following:
- declared, but not used parameters in the function. It's very common problem in the usage of $.each or in the event handlers. For example, the line
- value assigned, but not used in any execution path. For example the line.
- declaration of variable in the function with the same name as in the outer scope. For example, declaration i variable which can be easy renamed in j or k to fix the problem.
- the usage of variables which start with capical character, undescore (_) or the usage of undescore inside of the name.
- usage of possibly unassigned value.
- …
Description of all the small problems which are not really errors can get many time, but I could make the most clear and transparent changes (for example the first and the second problems from the list above) for beginning and post the results as a pull request. What do you think about?

Best regards
Oleg
Author

Replies