Guriddo » Topic: pager stops working when additional css classes are present !!!!

pager stops working when additional css classes are present !!!!

Guriddo
pager stops working when additional css classes are present !!!!

This topic has 5 replies, 2 voices, and was last updated 17 years, 3 months ago by Creativebyte.

Creator

Topic
July 27, 2008 at 2:00 pm #71916

Creativebyte
Participant

Hi tony,

I just searched for hours before I foudn this really nasty bug (well, in fact there are two).

Fist bug: I added additional css classes to my pager element for styling. Unfortunately, your code in the base js file (line 1013) checks if the class “scroll” is set, but exclusevely. So, if I add additional classes your if won't work!!!
Pelase change this asap so that the if checks if the class is present but pelase not exclusively.

second bug (and this is the really nasty one): When searching for the first bug I noticed that a second grid (almost same parameters) wored fine with its pager, the only big difference was that hiddengrid was set to true. So, I looked a long time before I saw the conclusion: when showing the contents of a hiddengrid, you leave the check of bug 1 aside, you just show the pager regardless if the class “scroll” is given or not (ignoring the user setttings). So, if it would have worked correctly, this pager wouldn't have worked as well because of bug 1, but since you don't do the same in both cases it works with a hiddengrid.

So please, please: get rid of bug1 and take care that in case of a hiddengrid everything is done accordingly to the normal behaviour (only “later”).

I will cahnge this in my code in the meantime but I hope that a bigfix release will come out soon. Until then, you should add to the documentation that the class “scrolL” has to be given exclusively to the pager.

BR,
Creativebyte
Creator

Topic

Viewing 5 replies - 1 through 5 (of 5 total)

Author

Replies
July 27, 2008 at 2:30 pm #82887

Creativebyte
Participant

Additonal notice:

Why do I need to give the pager the class “scroll” anyway? Can't you do it while setting up the pager? Would save a few bits and would help gettign around this check completely…

For solving bug1 I already did it in my code. Just exchange your if() with:

if( $(ts.p.pager).attr(“class”).search(/scroll/) != -1)

and it works. But for rewriting the hiddengrid method: I have no idea how to do it quickly and I am prettyl ucky that I need the pager there…

July 28, 2008 at 2:16 am #82890

tony
Keymaster

Thanks for this it will be corrected.

I think that a better way to check this is hasClass

The reason to set manual class of pager is that they can be put

where you want.

Thank you

Regards

Tony

July 28, 2008 at 2:39 am #82895

Creativebyte
Participant

Hi tony,

I don't get this reason. Of course I can put the pager html element where I want. But since you have the jQuery selector of the pager, this doesn't matter, does it?

So, in my opinion it's like this: when a pager selector is given you set the class scroll automatically. You could even bind this on viewrecords:true if you like.

BR,
Creativebyte

July 28, 2008 at 4:27 am #82899

tony
Keymaster

Hi,

I do not agree with this – if you set the pager where you want –

how will jqGrid known where to add buttons and etc

July 28, 2008 at 5:01 am #82900

Creativebyte
Participant

Sorry, I still don't get it. The only thing that jqgrid knows about the pager is just the jquery selector from the options array. By using this, you do everything, starting from showing the whole thing to adding buttons and navigation images to it. So, Why does it matter where the pager is?

Anyway: if you don't want to set the scroll class automatically it's ok.
Author

Replies