Guriddo » Topic: fixing width calculation of the grid in Google Chrome 19

fixing width calculation of the grid in Google Chrome 19

Guriddo
fixing width calculation of the grid in Google Chrome 19

This topic has 16 replies, 7 voices, and was last updated 13 years, 8 months ago by Albertz.

Creator

Topic
May 16, 2012 at 6:52 pm #79954

OlegK
Participant

Hallo Tony,

I have updated today my Chrome to version 19 and could reproduce the problem described here. I wrote my suggestions in my answer on the question. I post it here too.

As quick fix of the problem one can change the line
Creator

Topic

Viewing 15 replies - 1 through 15 (of 16 total)

1 2 →

Author

Replies
May 17, 2012 at 2:39 am #99837

johnmmackey@yahoo.ca
Participant

Thanks Oleg – fixed most of my problem!

May 17, 2012 at 9:56 am #99838

tony
Keymaster

Hello Oleg,

As usual – Thanks.

IMHO the better if we replace

isSafari = $.browser.webkit || $.browser.safari ? true : false;

with

var testcell = $(“

“).find(“td”).width(),

isSafari = ( ts.p.cellLayout != testcell );

This is better since it is unknown that with the next release it will be back.

Best Regards

Tony

May 17, 2012 at 12:48 pm #99839
gabbosam
Participant
tony said:

Hello Oleg,

As usual – Thanks.

IMHO the better if we replace

isSafari = $.browser.webkit || $.browser.safari ? true : false;

with

var testcell = $(“

“).find(“td”).width(),

isSafari = ( ts.p.cellLayout != testcell );

This is better since it is unknown that with the next release it will be back.

Best Regards

Tony

Hi tony,

the fix above must be have done into setGridWidth and ShowHideCol functions.

those functions use $.browser.webkit || $.browser.safari condition….

My fix is:
1. Store into a parameter isSafari flag. ts.p.isSafari = isSafari;
2. use that param in
May 17, 2012 at 1:00 pm #99840

tony
Keymaster

Hello,

Thanks. Fixed in GitHub using another approach, but the result is the same.

Regards

May 17, 2012 at 1:02 pm #99841

gabbosam
Participant

tony said:

Hello,

Thanks. Fixed in GitHub using another approach, but the result is the same.

Regards

Of course!

May 17, 2012 at 4:17 pm #99843

OlegK
Participant

Hallo Tony,

I named my suggestion at the beginning as quick and dirty solution, so I full agree that it would be fine to find in the future more better way. Nevetheless I don't think that the code which you wrote above will work correctly.

The first problem with above code is that ts.p.cellLayout can be set to 0. So the width of the table will be also 0. You fixed already the problem in the code of

May 17, 2012 at 8:23 pm #99844

tony
Keymaster

Hello Oleg,

Thanks. The function is fixed. Tested with 18 and 19 Chrom versions – return diffrent results

Regards

Tony

May 17, 2012 at 11:54 pm #99846

OlegK
Participant

Like corrently mention

May 18, 2012 at 9:45 am #99849

gabbosam
Participant

OlegK said:

Like corrently mention

May 18, 2012 at 3:49 pm #99851

master@alexandrem.com.br
Participant

I downloaded the commit on github but fixes only body, the header is unaligned

May 18, 2012 at 4:46 pm #99853

OlegK
Participant

Hi alexandrem,

You could see on the demo like this one

May 25, 2012 at 6:51 am #99861

johnmmackey@yahoo.ca
Participant

The bug has reappeared in Chrome 20 Beta

May 25, 2012 at 9:03 am #99862

OlegK
Participant

Thank you for information about Chrome 20 beta. I used information from wikipedia

May 25, 2012 at 2:00 pm #99865

johnmmackey@yahoo.ca
Participant

Thx Oleg – I was using the version you posted on stackoverflow, didn't grasp that the github version used a different approach.

August 31, 2012 at 4:28 am #100134

dreamcatcher
Participant

Problem still continue for subgrid and treegrid.
Author

Replies