Guriddo » Topic: Bug with idPrefix (duplicate idPrefix)

Bug with idPrefix (duplicate idPrefix)

Guriddo
Bug with idPrefix (duplicate idPrefix)

This topic has 7 replies, 4 voices, and was last updated 14 years, 1 month ago by maxfelipe.

Creator

Topic
January 18, 2012 at 5:02 pm #79534

Klaus Pesendorfer
Participant

Hello!

After updating jqGrid to the latest releases (jqGrid 4.3.1, jQuery 1.7.1) and using the new idPrefix option for my grids I detected the following problem:

In some cases the idPrefix is added/used twice for the table rows id attribute (… id=”pre_pre_12“). This problem seems to occur when using a grid with local data added via addRowData …

myTable.jqGrid(“clearGridData”);
myTable.jqGrid(“addRowData”, “id”, myData);
myTable.jqGrid('sortGrid', 'name', true, 'asc');

jqGrid calls the following internal functions: addRowData and then addJSONData for each row … I think this is the cause of the problem, why the prefix is added twice.

On the other hand, when using server side data (JSON) the ids are set correctly using the idPrefix only once. (… id=”pre_12“)

I've solved the problem by checking each time the prefix is appended, if it is already included in the ID and only add it if not.

But I don't think this is a really good solution. Maybe someone who knows the jqGrid code better could provide a clean bugfix for that problem.

Kind regards,
Klaus.
Creator

Topic

Viewing 7 replies - 1 through 7 (of 7 total)

Author

Replies
January 18, 2012 at 6:31 pm #99379

tony
Keymaster

Hello,

Do you have checked your myData?

Please veryfy that myData does not have any id with like pre_12 before it is added into the grid

Regards

January 18, 2012 at 7:07 pm #99380

Klaus Pesendorfer
Participant

Hello,

I've verified the data, and it is totally correct, but then I've found the exact position, when the problem happens … it is the sortGrid call and not the addRowData!

After the data was added with addRowData the ids where still correct, but after calling the sortGrid method the ids got wrong (with double-prefix)!

Here are some more details about my configuration:

tableSettings= {

May 2, 2012 at 6:59 am #99775

bigD
Participant

Hi

We are also seeing this issue, can you elaborate on your solution?

May 10, 2012 at 3:12 pm #99805

tony
Keymaster

Hello,

I hope that the problem is fixed.

Couild you please let us know which version is used.

Regards

May 18, 2012 at 8:11 am #99847

maxfelipe
Participant

I have the latest version (4.3.2) (with no code from github) and I'm also seeing the issue when the grid is sorted. I don't think Klaus actually fixed the issue, he was just pointing where he things the issue happens.

Moreover, I think the issue happens with any reload of the grid (filtering, sorting, etc)

Thanks again tony for such a great plugin.

May 18, 2012 at 9:25 am #99848

maxfelipe
Participant

Looks like I answered my own question, or at least a way to make it work. Looks like since I was using json data with loadonce: true, the id lookup for a reload was using the “localReader” id, which defaults to _id_(in our case 'idPrefixxx'). The reload then concatenates the idPrefix with the id retrieved from the row, leading to a duplicated idPrefix. If we use key:true in a col in our model that also represents the id of the row, we are all set, as the reload method will take *that* id instead of the rowid.

May 18, 2012 at 11:28 am #99850

maxfelipe
Participant

Shouldn't also this line be reversed on addRowData:

id = rowid;

rowid
Author

Replies