Thanks for this Oleg. Fixed.

Tony

Okay, I did some better testing and here are the method, followed by results.

My data has 337 rows and 3 columns. For every test I reload the page and perform the same action – which is to open the column chooser and hide one column (always the same). To measure performance I used Firebug's console.profile/End() around the $('option',select).each loop in the “apply_perm” function of columnChooser.

I did the test five times for each of the five versions of the code and averaged the times. First version is original. Second is with Oleg's original fix – $(this.cells).css(“display”, show);. Third one is with further simplfication via this.cells.style.display = show;. Fourth is with each loops replaced with for loops in the showHideCol function. Fifth and final one is where I replace the $('option',select).each part with a for loop.

1. 24173 calls, average time 451.4ms
2. 4453 calls, average time 311.4ms
3. 1393 calls, average time 283.4ms
4. 1045 calls, average time 279ms
5. 1026 calls, average time 277.2ms

Total (from 1 to 5) reduction in number of calls made is almost 24 times, and timing improved by almost 40%. Obviously the biggest improvement was going from 1 to 2, however, considering the triviality of further optimizations I see no reason not to implement all of them.

So the code inside showHideCol, i.e. this

$("tr",$t.grid.hDiv).each(function(){


Hello Oleg, 2late2die,

Thank you for the investigations, tests cases and recommendatins.

As 2late2die say the bigest speed improvements is from 1 to 2.

I will see how to implemet them

It is not neccessary to maybe to repace each, since this is not big improvements.

You maybe know this, but the fastest loop operator is while.

We can replace all the code with this one by example

var trs = $(“tr”,$t.grid.hDiv), trsL = trs.length,
trows = $($t.rows), trowsL = trows.length, j;

while( trsL–) {