Guriddo » Topic: Custom Input: Form Editing – Value not added to postdata sent to server

Custom Input: Form Editing – Value not added to postdata sent to server

Guriddo
Custom Input: Form Editing – Value not added to postdata sent to server

This topic has 9 replies, 3 voices, and was last updated 16 years, 5 months ago by Basdub.

Creator

Topic
November 18, 2009 at 9:34 am #74718

Basdub
Participant

Tony,

Just to have this as a seperate topic. The value from the custom input field is not sent to the server. The fix is very easy and might apply also for inline editing.

In file grid.formedit.js around line 543. you will find the following:

if($(this).hasClass(”customelement”))

In that situation, $(this) is in fact the container of the input element =>

Therefore it will never have the class customElement.

Solution:

Change

$(this)

to

$(this).children(”input”)[0]

PS: There might be a better way to get the child control. Would like to learn it!
Creator

Topic

Viewing 9 replies - 1 through 9 (of 9 total)

Author

Replies
November 18, 2009 at 9:40 am #90800

Basdub
Participant

That's not a good fix.

Maybe the “customelement” class should be set on the span element

November 18, 2009 at 2:10 pm #90805

Basdub
Participant

Ok, i got it to work. Assuming we want to keep the span surrounding the customelement…. which i think is good!

In grid.formedit.js around line 543

Replace

if($(this).hasClass("customelement")) {

November 18, 2009 at 2:20 pm #90806

Basdub
Participant

If someone wants to have a custom element with multiple input or whatever, this might not work properly.

November 18, 2009 at 3:33 pm #90808

Mark
Participant

Basdub said:

if($(this)[0].tagName === 'SPAN' && $(this).children(”input”).hasClass(”customelement”)) {

November 18, 2009 at 4:10 pm #90809

Basdub
Participant

Mark, that was just a quick fix. I totally agree with you on the fact that the custom element could be whatever we want, even further, it could be more than one control. See post 4!

I said in the post 4 that i would recommend to simply put the “.customelement” class flag on the tag that surrounds the custom control.

Maybe the span should be sent to the custom_value on a “get”. Then, you can work with whatever is inside that span and return the appropriate value.

All in all, that was a good catch from you. The “input” is way to much strict.

Regards,

November 19, 2009 at 4:39 am #90823

tony
Keymaster

Basdub,

I think that Mark is right. We should not be limited to input elements only, but to have a freedom to put what we want (this is the primary goal of the custom elements – otherwiese you can use the standart input and do evrething what you want with him)

I have put the fix provided from Mark and tested it and it seems to work. Beside from this there was another copy paste problem

The fix is in GitHub. Will be happy if it will work for you too.

Best Regards

Tony

November 19, 2009 at 8:20 am #90842

Basdub
Participant

Ok, how can i say this again: I AGREE WITH BOTH OF YOU!!!!

I'm just saying that the provided solution could be made EVEN MORE FLEXIBLE, as stated in POST 4 and in POST 6,

November 19, 2009 at 9:24 am #90843

Mark
Participant

Hi Tony,

I think you have a typo in your fix:

var

November 19, 2009 at 9:31 am #90844

Basdub
Participant

Good explanation Mark, thank you!

I guess yes in one scenario, one could wrap everything inside it's own span.

Good for me! I'll take that!

Thanks again

Regards,
Author

Replies